Skip to content

Use Rustc prefix for rustc attrs in AttributeKind #151827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 29, 2026
Merged

Use Rustc prefix for rustc attrs in AttributeKind #151827

rust-bors merged 1 commit into from
Jan 29, 2026

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 29, 2026 •
edited by rustbot
Loading

cc #131229

Most rustc_... attrs have their variants named RustcAttrName, but several do not. Rename these attributes for consistency.

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

⚠️ #[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

cc @rust-lang/wg-const-eval

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 29, 2026
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jan 29, 2026

At some point I even considered having a separate rustc attr enum so it would be Attr kind::RustC(RustcAttrKind::...). We can always still do that of course, not sure if we want that. But I do think this is nice for consistency. Dya agree @JonathanBrouwer?

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jan 29, 2026

r=me if you ack Jonathan, just want you to also be aware of changes here

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 29, 2026 •
edited
Loading

This change makes a lot of sense to me. Thanks for making me aware :)
I'm not entirely sure of the value of a seperate enum for Rustc, mostly just think it will make the pattern matching in find_attr! slightly uglier, but don't have strong opinions about that.

@bors r=jdonszelmann,JonathanBrouwer rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 29, 2026

📌 Commit 02bd3e8 has been approved by jdonszelmann,JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2026
@clubby789 clubby789 mentioned this pull request Jan 29, 2026
Merged
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 29, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 29, 2026
@bors
Auto merge of #151835 - JonathanBrouwer:rollup-ayQY8NW, r=JonathanBro…
842bd5b 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #147387 (hir_owner_parent optimized to inlined call for non-incremental build)
 - #150271 (Move struct placeholder pt2)
 - #151283 (Suggest ignore returning value inside macro for unused_must_use lint)
 - #151565 (Rename, clarify, and document code for "erasing" query values)
 - #149482 (thread::scope: document how join interacts with TLS destructors)
 - #151827 (Use `Rustc` prefix for `rustc` attrs in `AttributeKind`)
 - #151833 (Treat unions as 'data types' in attr parsing diagnostics)
 - #151834 (Update `askama` version to `0.15.4`)
@rust-bors rust-bors bot merged commit 35c608b into rust-lang:main Jan 29, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 29, 2026
rust-timer added a commit that referenced this pull request Jan 29, 2026
@rust-timer
Unrolled build for #151827
74a6d24 
Rollup merge of #151827 - clubby789:rustc-attr-names, r=jdonszelmann,JonathanBrouwer

Use `Rustc` prefix for `rustc` attrs in `AttributeKind`

cc #131229

Most `rustc_...` attrs have their variants named `RustcAttrName`, but several do not. Rename these attributes for consistency.

r? @jdonszelmann
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 30, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151831 - clubby789:port-rustc-layout, r=Jon…
63e8456 
…athanBrouwer

Port `rustc_layout` to attribute parser

Tracking issue: rust-lang#131229

Uses rust-lang#151827

r? jdonszelmann
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 30, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151831 - clubby789:port-rustc-layout, r=Jon…
e19cb30 
…athanBrouwer

Port `rustc_layout` to attribute parser

Tracking issue: rust-lang#131229

Uses rust-lang#151827

r? jdonszelmann
@github-actions github-actions bot mentioned this pull request Jan 30, 2026
Draft
rust-timer added a commit that referenced this pull request Jan 30, 2026
@rust-timer
Unrolled build for #151831
6249d5d 
Rollup merge of #151831 - clubby789:port-rustc-layout, r=JonathanBrouwer

Port `rustc_layout` to attribute parser

Tracking issue: #131229

Uses #151827

r? jdonszelmann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@clubby789 @rustbot @jdonszelmann @JonathanBrouwer @jamie-osec